-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDF5 Read & Write #111
HDF5 Read & Write #111
Conversation
@@ -946,29 +979,149 @@ def SetFileName(self, value): | |||
def GetFileName(self): | |||
return self.__FileName | |||
|
|||
|
|||
|
|||
class cilHDF5ImageResampleReader(cilBaseResampleReader): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change to conversion.py that isn't just formatting is the addition of this cilHDF5ImageResampleReader
class
Note: |
See #127 for improvements to structure of the resample reader |
Once #150 is working and merged, can check that the HDF5 test runs with the gh-action, and then will merge this |
The unit tests pass locally but currently fail when run in the github action. Maybe there's a problem with writing the files? |
It is now fixed! |
Waiting on fix of #150, otherwise we agreed this was ready |
HDF5Reader
, and reading a cropped version of the image withRequestSubset
write_image_data_to_hdf5
cilHDF5ImageResampleReader
To do: