Viewer slider #365
Merged
Viewer slider #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires TomographicImaging#235 to be fixed to successfully reset on new image loaded
add vertical orientation for the slider
paskino
commented
Sep 11, 2023
|
TODO:
|
…#362) * closes Downsampling should use round rather than int TomographicImaging#359 * update unittest and remove temporary test files * use pytest in action * move functionality to utils.conversion
…into viewer_slider
DanicaSTFC
requested changes
Feb 19, 2024
| self.bar_ends_color = 'Yellow' | ||
|
|
||
|
|
||
| def get_slider_widget(self, orientation='horizontal', offset=0.12): |
There was a problem hiding this comment.
I understand this method returns the widget but more importantly it creates it. Can we change the name to "Make" or "Create" or similar?
DanicaSTFC
requested changes
Feb 19, 2024
|
I tested on Windows and magma data .npy and it seemed to work correctly. |
|
I changed the bar colour back to gray. The previous magenta was not giving enough contrast with the viewer blue background.
|
DanicaSTFC
reviewed
Apr 5, 2024
DanicaSTFC
reviewed
Apr 5, 2024
DanicaSTFC
requested changes
Apr 17, 2024
DanicaSTFC
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a slider widget to control the slice that is being displayed. Both the mouse wheel and this slider can be used to change the slice.
A
SliceSliderRepresentationwith default colors (CIL pinks), orientation (horizontal) and position is introduced.Closes #358
The orientation and position of the slider can be changed.
I tested on Windows with the web app and it doesn't seem to be able to grab the slider.