Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link slider events #413

Merged
merged 9 commits into from
Jun 6, 2024
Merged

link slider events #413

merged 9 commits into from
Jun 6, 2024

Conversation

paskino
Copy link
Collaborator

@paskino paskino commented Jun 5, 2024

Describe your changes

Adds logic to viewer linker to keep in sync slices on 2 viewers

Describe any testing you have performed

Consider adding example code to examples

Link relevant issues

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the CIL developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'waiting for review'

Contribution Notes

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CILViewer (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

Qt contributions should follow Qt naming conventions i.e. camelCase method names.

VTK contributions should follow VTK naming conventions i.e. PascalCase method names.

@DanicaSTFC
Copy link
Collaborator

DanicaSTFC commented Jun 6, 2024

Tested on magma data, works well and improved the experience of the slider drastically

@paskino paskino merged commit 608f9d9 into master Jun 6, 2024
3 checks passed
@paskino paskino deleted the link_slider_event branch June 6, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

xyz press should update the slice shown Linker does not monitor and link slider events
2 participants