-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate requirements in files and folders #451
Open
DanicaSTFC
wants to merge
24
commits into
master
Choose a base branch
from
remove-eqt-dependencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanicaSTFC
changed the title
Remove eqt dependencies
Separate requirements in files and folders
Jan 22, 2025
DanicaSTFC
commented
Jan 27, 2025
paskino
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
ui_env.yml
fileRelated Issues
Documentation edits:
UI folder & ui_eqt_examples depends on
eqt
pyside2
cil-data
create extra env file for this.
EQT
opacity_in_viewer
in it.pyside2
BoxWidgetAroundSlice
,FourDockableLinkedViewerWidgets
... in the new folder."A QVTKRenderWindowInteractor for Python and Qt. Uses a vtkGenericRenderWindowInteractor to handle the interactions. Use GetRenderWindow() to get the vtkRenderWindow. Create with the keyword stereo=1 in order to generate a stereo-capable window."
https://docs.vtk.org/en/latest/api/python/vtkmodules/vtkmodules.qt.QVTKRenderWindowInteractor.html
schema
We leave it in the requirements.
Files in which it appears:
h5py
It seems important, we can leave it in the requirements.
Files in which it appears:
cil-data
Files in which it appears:
setuptools
Only needed in the conda build as a fundamental requirements to build with python.
pyyaml
I cannot see it used anywhere. probably used in schema.
importlib_metadata
needed for python 3.7
Describe any testing you have performed
I ran all the examples, and I ran the tests locally as well as passing all the CI tests.
@paskino ran on Windows:
I successfully ran
viewer2D-without-qt.py
and a test withtrame
and the viewer in jupyter (all experimental code currently not available).Checklist when you are ready to request a review
Contribution Notes
Qt contributions should follow Qt naming conventions i.e. camelCase method names.
VTK contributions should follow VTK naming conventions i.e. PascalCase method names.