Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SessionDirectorySelectionDialog Disappearing #163

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

jcornall
Copy link
Collaborator

@jcornall jcornall commented Nov 27, 2024

Closes #162

Relates to CIL-GUI issue #286 and pull request #287

After starting CIL-GUI using the epac_ct command, the splash screen appears. Shortly afterwards, the SessionDirectorySelectionDialog appears briefly before closing, the program then exits with Exit Code 1.

Changing the .open() call to .exec() allows the dialog to persist without automatically closing.

@jcornall jcornall requested a review from DanicaSTFC November 27, 2024 11:15
@jcornall jcornall self-assigned this Nov 27, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@DanicaSTFC DanicaSTFC marked this pull request as ready for review November 27, 2024 11:29
@jcornall jcornall requested a review from DanicaSTFC November 27, 2024 11:52
@jcornall jcornall merged commit c1dbd6f into main Nov 27, 2024
6 checks passed
@jcornall jcornall deleted the fix-session-dialog branch November 27, 2024 12:11
@jcornall
Copy link
Collaborator Author

@DanicaSTFC DanicaSTFC added this to the Version x.x.x milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SessionDirectorySelectionDialog appears then closes instantly
2 participants