Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename files if copied in session as reference and correlate #186

Merged
merged 13 commits into from
Apr 20, 2023

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Mar 9, 2023

closes #184

@paskino paskino requested a review from lauramurgatroyd March 9, 2023 20:06
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this does not work for tiffs - I get the following error:
image

And on the command line it gives an error: "When reading multiple files, all files must TIFF formatted."

I believe what is happening is it copies every tiff file to have the same new name, so they all overwrite each other.

src/idvc/dvc_interface.py Outdated Show resolved Hide resolved
@paskino paskino requested a review from lauramurgatroyd March 30, 2023 12:46
@paskino
Copy link
Contributor Author

paskino commented Mar 30, 2023

I think I fixed the behaviour, but see also #193

@paskino paskino mentioned this pull request Apr 2, 2023
Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered a couple of issues:

  • When I encountered an error when clicking "Visualise" [I think the error was due to trying to downsample a compressed .mha file? ] I had the error message pop up, but the progress dialog remained in place.

  • Issues with .mhd files, as the .mha created is compressed so can't be read by the resample reader. [ see comment ]

src/idvc/dvc_interface.py Outdated Show resolved Hide resolved
src/idvc/dvc_interface.py Show resolved Hide resolved
paskino and others added 2 commits April 4, 2023 23:35
Co-authored-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
Co-authored-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
@lauramurgatroyd lauramurgatroyd self-requested a review April 19, 2023 19:57
@lauramurgatroyd
Copy link
Member

Just fixed this issue:

When I encountered an error when clicking "Visualise" [I think the error was due to trying to downsample a compressed .mha file? ] I had the error message pop up, but the progress dialog remained in place.

@lauramurgatroyd lauramurgatroyd merged commit 81a45db into master Apr 20, 2023
@paskino paskino deleted the rename_files_on_load branch July 21, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants