Avoid type errors in EAI-related name check logic. #652
+144
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongbeiouba
force-pushed
the
fix/CVE-2024-6119
branch
from
5693638
to
5acfd6d
Compare
dongbeiouba
requested review from
InfoHunter,
uudiin,
wa5i,
zzl360 and
a team
The incorrectly typed data is read only, used in a compare operation, so neither remote code execution, nor memory content disclosure were possible. However, applications performing certificate name checks were vulnerable to denial of service. The GENERAL_TYPE data type is a union, and we must take care to access the correct member, based on `gen->type`, not all the member fields have the same structure, and a segfault is possible if the wrong member field is read. The code in question was lightly refactored with the intent to make it more obviously correct. Fixes CVE-2024-6119 (cherry picked from commit 06d1dc3fa96a2ba5a3e22735a033012aadc9f0d6)
dongbeiouba
force-pushed
the
fix/CVE-2024-6119
branch
from
5acfd6d
to
ef44297
Compare
|
ping @Tongsuo-Project/tongsuo-maintainers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrectly typed data is read only, used in a compare operation, so neither remote code execution, nor memory content disclosure were possible. However, applications performing certificate name checks were vulnerable to denial of service.
The GENERAL_TYPE data type is a union, and we must take care to access the correct member, based on
gen->type, not all the member fields have the same structure, and a segfault is possible if the wrong member field is read.The code in question was lightly refactored with the intent to make it more obviously correct.
Fixes CVE-2024-6119
Checklist