Ability to hide rows/cols #480
Conversation
* Add `hiddenRowRanges` * Update `getFilteredAndSortedViewData` to support hidden rows * Add public methods `hideRows` and `unhideRows`
* Add method `getSelectedContiguousRows`
* Add `currentRowIndexOffset` and `rowIndexOffsetByHiddenRows` to make the current row index model is compatible with hidden rows. * Hide the row gap indicator(a bold black line) for the hidden rows.
* And call this method in the `stopDragMove` to fix incorrect values in `scrollCache.x`
|
@hangxingliu I'm a little tied up this week, but can look early next, unless @TonyGermaneri wants to review it? |
|
@hangxingliu, thanks a lot for this — this is great work, and I really appreciate the effort you've put into the tests. Beyond nitpick-stuff (which I won't mention because it's not important), I found nothing worth mentioning. It all looks pretty good. (Although the only nitpick I might mention would be to add some more more vertical spacing, i.e. empty lines, here and there to separate some of the logical blocks for legibility). It is, tough, a lot of code, so while I've tried to go through it diligently I may have missed some things. If so: apologies :-) |
|
@ndrsn Thanks for your appreciation and your work. And you can leave the comments on the code for me if you want. Because sometimes I am focus on the the logic of the code but forget about legibility. |
* Fix the behavior of the conext menu item used to hide column * Add new attributes and styles for hide contiguous columns/rows * Update context menu to support hiding multiple columns * Update event handlers for unhide indicator * Rename `strokeLines` to `drawLines` * Fix unresolved merge conflict * Add methods and properties for the feature of unhide indicator * Implement the render of the unhide indicator * Update the render of unhide indicators on row headers * Add util function `mergeHiddenRowRanges` and unit tests. * Update methods and properties for hide/unhide feature * Add `hiddenRowRanges` * Update `getFilteredAndSortedViewData` to support hidden rows * Add public methods `hideRows` and `unhideRows` * Update context menu for hiding rows * Add method `getSelectedContiguousRows` * Update click event handler to support unhide rows * Update `draw.js` to support hidden rows * Add `currentRowIndexOffset` and `rowIndexOffsetByHiddenRows` to make the current row index model is compatible with hidden rows. * Hide the row gap indicator(a bold black line) for the hidden rows. * Update `draw.js` for unhide indicator * Fix jsDoc * Extract a new method `refreshScrollCacheX` from the method `resize` * And call this method in the `stopDragMove` to fix incorrect values in `scrollCache.x` * Fix `Cannot read 'context' of undefined` * Add method `hideColumns` * Fix the relationship between unhide indicator and dragging * Fix generating codes of`visibleUnhideIndicators` * Fix incorrect indexes in row headers when the first row is hidden * Add tests for unhide indicator * Add util functions for tests * Fix tests for unhide indicator
Related issue #420
And this PR doesn't need to be merged now. I am still adding the UI tests and documents for it. I create a PR first for everyone can have a look now. And you can leave messages here if you find any bugs with this new feature. Thanks