Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to override worker thread allocation logic in WebSocketServer #279

Closed
ghost opened this issue Sep 11, 2014 · 2 comments
Closed
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Sep 11, 2014

Hey, may I ask you for accepting a PR that does just 2 minor things, making

WebSocketServer#decoders 
WebSocketServer#queue

protected field/method in order to do what's described here in the server's description :
https://github.com/viagraphs/reactive-websocket
https://github.com/viagraphs/reactive-websocket/blob/master/jvm/src/main/scala/com/viagraphs/websocket/RxWebSocketServer.scala#L69

I'd like to contribute to Java-WebSocket in following several months when I'm gonna build a project around it.

@BrushfireDigitalServices
Copy link
Collaborator

@viagraphs On behalf of the whole Java-Websockets project, apologies for not getting to this sooner. This project is being actively administrated again, and any and all pull requests are welcome.

We are currently pushing to complete documentation (#313) and expand unit test coverage in anticipation of a new stable release. The new release prioritizes fixing our wss and race condition bugs, and may include new features.

Yours would be an excellent feature for inclusion. If you are still interested, please send us pull requests, participate in discussions, etc.

@marci4
Copy link
Collaborator

marci4 commented May 28, 2017

Thank you for your work!

Merged your changes into main branch!
Greetings
marci4

@marci4 marci4 closed this as completed May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants