Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null the reference of the WebSocketImpl #781

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Null the reference of the WebSocketImpl #781

merged 1 commit into from
Sep 25, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Sep 25, 2018

Description

Null the reference to ensure that gc can clean up everything

Related Issue

Fixes #773

Motivation and Context

Memory leak

How Has This Been Tested?

Confirmed by reporter and checked with profiler

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.4.0 milestone Sep 25, 2018
@marci4 marci4 merged commit b1fd0ce into TooTallNate:master Sep 25, 2018
@marci4 marci4 deleted the Issue773 branch September 25, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Server
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.

Memory leak in WebSocketImpl.outQueue
1 participant
@marci4