-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build failing with node v12 #92
Comments
I'm having this issue too when running electron build. Hope this will get fixed soon. |
I have the same error but i downgraded my node 12 to 11.6.0 (last node 11 version) and it worked |
Have the same issue, as workaround using node v10 |
node 10 can't be used in some contexts (like with NodeGui), so this is a fairly significant problem. |
I went ahead and spent an afternoon replacing the old Nan deprecated calls, now the package builds successfully for Node 12 without any warnings or errors. I made a PR, but until it's accepted, feel free to use this fork: https://github.com/suldashi/node-lame |
I can confirm it works ok on node 12. Looking forward to get this published on npmjs.com. |
Looking forward to seeing this change on NPM |
When publish? ;( |
I think @TooTallNate stopped maintaining this package. Last commit was in 2018 and it was the only one that year. Maybe you should publish your fork as a new npm package @suldashi ? |
It's not necessarily unmaintained just because it's rarely updated, maybe there's nothing to update? In any case, I was in touch with the original author a few weeks ago and he is aware of the issues and has promised to fix it. I just published this package on NPM and you can use it as usual. The name is Install using |
Thanks a lot for this! I've been trying to install lame for hours and wasn't able to. Yours worked flawlessly! |
module build is failing while using nodejs version > 12
build log:
The text was updated successfully, but these errors were encountered: