This repository has been archived by the owner on May 5, 2023. It is now read-only.
Release upgrade of socks-proxy-agent to 4.x #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2018
This was referenced Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
sockswas updated to 4 which was a breaking change for Node < 6.So the change was reverted and a new major version was released.
Unfortunately, the new major announced an upgrade to
sockswithout actually implementing it.This was addressed by this PR but a new release was not created (Note that
65fcf7ais one commit behind master).Consequently, some issues are blocked on getting access to the
socksupgrade.Solution:
Please consider merging this PR and creating a new 3.0.1 release.