-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAC proxy with *_PROXY
env vars is broken
#219
Comments
Whoops, ya, good catch. |
TooTallNate
added a commit
that referenced
this issue
Jul 13, 2023
TooTallNate
added a commit
that referenced
this issue
Jul 13, 2023
Fixed in proxy-agent v6.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With
proxy-agent@5.0.0
, the following code worked (example taken from here):Test command line (this uses a PAC file which only returns
"DIRECT"
):After upgrading to
proxy-agent@6.2.1
(and doing this little change:)Then it fails with this:
I think that's because
isValidProtocol()
proxy-agents/packages/proxy-agent/src/index.ts
Lines 133 to 135 in 08487f0
uses those protocols:
proxy-agents/packages/pac-proxy-agent/src/index.ts
Lines 58 to 64 in 08487f0
The text was updated successfully, but these errors were encountered: