Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass proxy certificates to TLS query #111

Closed
wants to merge 4 commits into from

Conversation

ArturAralin
Copy link

Reason: some services uses self-signed certificates for communication (or authorization), but currently certs passed only to proxy server not to target service.

Solution: pass certificates to tls query to target service

@LuizFelipeNeves
Copy link

Please merge!

@cupofjoakim
Copy link

@TooTallNate Mind giving this a look? Would help a lot!

@pauldraper
Copy link

This would have saved me hours.

@FrankEssenberger
Copy link

FrankEssenberger commented Mar 3, 2021

I also had the problem that client certificate auth did not work via the proxy agent. I added the proposed manually to our node_modules and it did the trick that the certificate are also forwarded to the target system. Would be nice to get this in the main code line.

@barroudjo
Copy link

Yep I agree this would be a great addition. We actually need this in our team !

@dscalzi
Copy link

dscalzi commented Jun 15, 2021

workaround while this is being ignored: #89

patrickheeney added a commit to evocode/node-https-proxy-agent that referenced this pull request Oct 4, 2021
@dscalzi
Copy link

dscalzi commented Dec 1, 2021

@TooTallNate bump? Libraries like https://github.com/delvedor/hpagent support this out of the box.

@TooTallNate
Copy link
Owner

You should be passing in options meant for the destination endpoint directly to https.get(). The options passed in the Agent constructor are meant for the connection to the proxy server.

@TooTallNate TooTallNate closed this May 4, 2023
@pmuellr
Copy link

pmuellr commented Oct 22, 2024

For folks following the various TLS threads here ...

I'm in a sticky wicket here ... I'm using axios, but it doesn't seem to have a way to send https config along with a request. The way I've seen it done there is by using a customized http agent. And we're using the https-proxy-agent as our agent, which doesn't seem to support setting https options for the target, just the proxy.

Torn between using hpagent, the subclass trick with callback, or see if I can chain multiple agents - I guess I want an ordinary https agent, which then chains to the proxy agent, but no idea if this is supported, or will cause other issues ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants