Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URL imports for Node 14 #289

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

danielbankhead
Copy link
Contributor

The following PR introduced a regression in Node 14, as that version of node doesn't support node:url.

Original issue:

Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: bbb4c39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
http-proxy-agent Patch
https-proxy-agent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Feb 15, 2024 6:57pm

@TooTallNate
Copy link
Owner

This really should not be necessary. node:url import works even on Node 14. The error probably comes from a bundler which does not understand that syntax.

Anyways, I'll merge this because there have been a few reports of this error and I'm tired of trying to explain to people that it's a misconfiguration on their end 🤷

@TooTallNate TooTallNate merged commit b88ab46 into TooTallNate:main Feb 15, 2024
15 checks passed
@danielbankhead
Copy link
Contributor Author

Thanks for merging. You are correct that it does work in Node 14, but not all versions of 14 (and technically the engines field includes 14.0.0):

Screenshot 2024-02-15 at 12 09 31 PM

@danielbankhead danielbankhead deleted the fix-url-import-node-14 branch February 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants