Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net.isIP() check for TLS servername #312

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

TooTallNate
Copy link
Owner

Fixes #308.

Copy link

changeset-bot bot commented Apr 6, 2024

🦋 Changeset detected

Latest commit: a1a353c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
https-proxy-agent Patch
pac-proxy-agent Patch
socks-proxy-agent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
proxy-agents ✅ Ready (Inspect) Visit Preview Apr 6, 2024 6:03am

@TooTallNate TooTallNate marked this pull request as ready for review April 6, 2024 06:07
@TooTallNate TooTallNate merged commit 5908e84 into main Apr 6, 2024
15 checks passed
@TooTallNate TooTallNate deleted the remove/net-isip branch April 6, 2024 06:07
mxschmitt added a commit to mxschmitt/proxy-agents that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificates with IP addresses does not work with this change
1 participant