Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a CI action with proxy services #49

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

robbkidd
Copy link
Contributor

@robbkidd robbkidd commented Aug 2, 2023

  • adds a GitHub Actions workflow to run the tests with two live proxies (HTTP/s and SOCKS) for integration testing
  • updates the tests:
    • use different target sites
    • check the new target content
    • skip the proxy integration tests if environment variables are not set
  • includes the docker-compose config I used to test things locally and on which I set up the CI GitHub Action

This is not a very exciting PR without the workflow approved for running in this repo. Witness the success over in my fork.

Update tests to use the CI proxies and different target sites.
@TooTallNate TooTallNate merged commit 284da93 into TooTallNate:master Aug 2, 2023
@robbkidd robbkidd mentioned this pull request Aug 2, 2023
@TooTallNate
Copy link
Owner

Thanks! Seems like CI didn't kick off after merge though. Perhaps something isn't configured correctly in the workflow file?

@robbkidd
Copy link
Contributor Author

robbkidd commented Aug 2, 2023

Perhaps something isn't configured correctly in the workflow file?

Perhaps! I'll look into it!

@robbkidd
Copy link
Contributor Author

robbkidd commented Aug 2, 2023

Except … it seems it did run on the merged commit, GitHub's just not sprinkling the green check on the commit. 😕

@robbkidd
Copy link
Contributor Author

robbkidd commented Aug 2, 2023

Brain dumping how to use Docker for running tests locally in dev.

❯ docker-compose up --detach
❯ docker-compose exec test npm install
❯ docker-compose exec test npm test
# make modifications, repeat install and/or test as appropriate
# when done
❯ docker-compose down

I notice again that the project has a yarn.lock. Those commands could have yarn swapped out for npm. I could update the CI workflow to run yarn instead, if you would prefer, @TooTallNate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants