Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all HTTP errors #378

Closed
silentjohnny opened this issue Oct 10, 2023 · 0 comments · Fixed by #379
Closed

Handle all HTTP errors #378

silentjohnny opened this issue Oct 10, 2023 · 0 comments · Fixed by #379

Comments

@silentjohnny
Copy link
Contributor

When an HTTP error occurs, e.g., a 400, node-gcm should respond with the status of the error

Right now, only 401 and 500 are handled, but other HTTP errors should be handled too.
silentjohnny added a commit to Notificare/node-gcm that referenced this issue Oct 10, 2023
@silentjohnny
fix: handle all HTTP errors correctly (ToothlessGear#378)
0be3458
@silentjohnny silentjohnny mentioned this issue Oct 10, 2023
Merged
eladnava pushed a commit that referenced this issue Oct 10, 2023
@silentjohnny
Handle all HTTP errors correctly (#379)
a235d24 
* fix: handle non-http errors correctly (#375)

* fix: handle all HTTP errors correctly (#378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle all HTTP errors correctly Notificare/node-gcm
1 participant
@silentjohnny