Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump dependencies #353

Closed
wants to merge 2 commits into from

Conversation

mtrezza
Copy link
Collaborator

@mtrezza mtrezza commented Aug 26, 2021

  • bumps dependencies
  • reduces vulnerabilities from 4 vulnerabilities (1 low, 2 moderate, 1 high) to 1 low

@mtrezza
Copy link
Collaborator Author

mtrezza commented Aug 26, 2021

@ToothlessGear could you please review this PR and make a release to fix the vulnerabilities?

@eladnava
Copy link
Collaborator

eladnava commented Aug 28, 2021

@mtrezza Thanks for your contribution and suggestion!

I believe it would be preferred by @ToothlessGear and @hypesystem if we only were to update those dependencies with vulnerabilities reported by npm audit, which are lodash and mocha (dev).

I've gone forth and updated the dependencies in f268b8b and published to npm in 1.0.5. Thanks for your help!

@eladnava eladnava closed this Aug 28, 2021
@mtrezza
Copy link
Collaborator Author

mtrezza commented Aug 28, 2021

Thanks for the fast release @eladnava, yes that sounds good and I'll keep that in mind for future PRs.

May I suggest to add snyk to this repository to fix vulnerabilities faster and without having to wait for a manual PR? These vulnerabilities were open for quite some time. #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants