-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide example data #29
Conversation
Regarding the repository that contains the examples, right now, it's the https://github.com/wschwanghart/DEMs repository. So we might want to fork it to If implemented, this should resolve #9 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, @Teschl. This should be sufficient for our testing and documentation purposes at the moment. I suggested a few changes that make sense right now.
In the future, we might want to think about other ways that users might want to access data and how we can accomodate them. The MATLAB TopoToolbox provides, for example, a way to access the OpenTopography API that could be nice to have across our packages.
Excellent. I think it's generally a good idea to host also the example DEMs
on git although git is not really made for data hosting. However, so far it
supports file sizes up to 50 Mb. We might also consider this here:
https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-git-large-file-storage
Am Di., 28. Mai 2024 um 19:57 Uhr schrieb William Kearney <
***@***.***>:
… https://github.com/TopoToolbox/DEMs
—
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4RU3DYTAE46OS3KWBL3GDZETASNAVCNFSM6AAAAABIM4D7ROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVHAZDGMRWGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I have addressed the more bug-fix related requested changes.
and maybe adding |
In this pull request, I added the following functions:
topotoolbox.load_dem()
enter DEM name as argument, it will download the tif if it isn't already cached.topotoolbox.get_dem_names()
will return a list of all available tifs forload_dem()
. if we add a .txt which contains all names to the repository which contains the tifs, we can implement it more dynamically. (right now it's just a list in the .py file)topotoolbox.read_tif()
is a wrapper for creating a GridObject. Could be a cleaner way to create a GridObject inspired by pandas (pandas.read_csv creates a pandas.Dataframe).Since the function
get_save_location()
inutils.py
is not listed in__all__
it's not automatically imported when using the package. This way it's "private" and not usable for the user by default.I also fixed some line length issues in the mixin files for the GridObject. The maximum line length is 79 chars.