Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/use default card style #12

Merged
merged 16 commits into from
Jan 26, 2022
Merged

UI/use default card style #12

merged 16 commits into from
Jan 26, 2022

Conversation

oyisre
Copy link
Collaborator

@oyisre oyisre commented Jan 21, 2022

No description provided.

@oyisre oyisre self-assigned this Jan 21, 2022
@oyisre oyisre assigned joshcds and unassigned oyisre Jan 24, 2022
@joshcds
Copy link

joshcds commented Jan 26, 2022 •
edited
Loading

Hey @oyisre

I noticed that you switched back these lines to hardcoded text for the resource type:
https://github.com/PuraJuniper/SAGE/blob/648123b315f568b2b059b48ef29d24f88929544b/src/simplified/baseCard.tsx#L63

https://github.com/PuraJuniper/SAGE/blob/648123b315f568b2b059b48ef29d24f88929544b/src/simplified/selectView.tsx#L35

Would it be alright to replaced those Strings with ACTIVITY_DEFINITION and QUESTIONNAIRE from the nameHelpers.tsx respectively?

@joshcds
Copy link

joshcds commented Jan 26, 2022

Made a few refactored changes and will complete

@joshcds joshcds merged commit 8e5a409 into develop Jan 26, 2022
@oyisre oyisre deleted the ui/use-default-card-style branch March 1, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcds joshcds joshcds approved these changes

Assignees

@joshcds joshcds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oyisre @joshcds