Theory-specific help #269
Draft
Theory-specific help #269
+76
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatters
added
enhancement
epatters
force-pushed
the
doctheoryhelp1
branch
from
6d7a823
to
b70c493
Compare
epatters
requested changes
Nov 26, 2024
| @@ -45,6 +45,8 @@ export function TheorySelectorDialog( | |||
| ); | |||
| } | |||
|
|
|||
| export const [selectedTheory, setSelectedTheory] = createSignal<string | undefined>(undefined); | |||
There was a problem hiding this comment.
I don't know if creating a signal outside of a component, for example at the top level like here, will work. More importantly, we shouldn't need to create a new signal at all. The selected theory is already available from the LiveModelDocument. See below.
| <CircleHelp /> | ||
| </IconButton> | ||
| ); | ||
| if (selectedTheory() == null) { |
There was a problem hiding this comment.
Instead of using selectedTheory(), create a TheoryHelpButton that takes the theory ID (or undefined) as a prop. Then pass the theory as props.liveModel.theory() from inside the ModelDocumentEditor.
| @@ -0,0 +1,46 @@ | |||
| import { readdirSync, statSync, writeFileSync } from "node:fs"; | |||
| import { join, resolve } from "node:path"; | |||
There was a problem hiding this comment.
This will not work because you're using Node-specific APIs, which are not available in the browser. That's why the CI is failing. We can discuss alternative approaches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theory-specific help
(PR is incomplete, routing isn't working)