-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable additional aesthetics in pitch annotation (linewidth
, alpha
, linetype
)
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reversing the coordinates; it seems better to avoid transforming the input data if we can.
size, alpha, and linetype
Such that linetype doesn't clash
So that lines connect nicely at high linewidths
@lvanden - I can't add you as a reviewer (I think I might need to add you as a "collaborator" or something for that?), but I thought I'd put this up as a PR in case you wanted to have a look. (It's a little late, but in my defence, I didn't say which Christmas break I would have some time in! 😅) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few main changes to enable additional pitch aesthetics. Taken all together it's quite large, and I should have broken it up, but the key changes are more or less contained in a few commits which will be easier to browse than the full diff:
geom_curve
to draw penalty box arcs (instead of drawing a full circle withgrid::circleGrob
): e991106linewidth
,alpha
,linetype
aesthetics to the arguments forannotate_pitch
: 8cb51b8geom_segment
s (instead ofgeom_rect
), so that there's no overlap with the whole-pitch outline (would interfere withlinetype
): a5e925fNB: I also used
linewidth
as the top-level aesthetic oversize
(0af098a), since this was deprecated for lines in the latest ggplot2 release (3.4.0), although the points (penalty spots and centre point) takesize = linewidth
as well.Some example images of what this looks like with different aesthetics:
Created on 2022-11-30 with reprex v2.0.2
Closes #10, closes #17, closes #18, and closes #23