-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher with problems to accept args in 6.1.0 #94
Labels
All platforms
Issue related to the all platforms
bug
Something isn't working
good first issue
Good for newcomers
Comments
acmlira
added
good first issue
Good for newcomers
java
All platforms
Issue related to the all platforms
labels
Aug 6, 2020
acmlira
added a commit
that referenced
this issue
Aug 6, 2020
The */r* argument was the argument that referenced TotalCross's serial license number. To keep backwards compatibility, we just skipped what it would do, but we didn't do it the right way. This patch adjust the argument iterator, it has no effect when being incremented within the `if`.
The removal of the key system left this residue in ...
System.out.println("Screen is " + toWidth + "x" + toHeight + "x" + toBpp);
} else if (args[i++].equalsIgnoreCase("/r")) {
// Ignore next argument
} else if (args[i].equalsIgnoreCase("/pos")) /* x,y */
... the code was waiting for the serial number that should not be passed anymore! I made a pull request to fix |
acmlira
added a commit
that referenced
this issue
Aug 7, 2020
adjust array iterator, it has no effect when being incremented within the if
ItaloYeltsin
pushed a commit
that referenced
this issue
Aug 7, 2020
The */r* argument was the argument that referenced TotalCross's serial license number. To keep backwards compatibility, we just skipped what it would do, but we didn't do it the right way. This patch adjust the argument iterator, it has no effect when being incremented within the `if`.
ItaloYeltsin
pushed a commit
that referenced
this issue
Aug 10, 2020
The */r* argument was the argument that referenced TotalCross's serial license number. To keep backwards compatibility, we just skipped what it would do, but we didn't do it the right way. This patch adjust the argument iterator, it has no effect when being incremented within the `if`.
flsobral
pushed a commit
that referenced
this issue
Aug 11, 2020
The */r* argument was the argument that referenced TotalCross's serial license number. To keep backwards compatibility, we just skipped what it would do, but we didn't do it the right way. This patch adjust the argument iterator, it has no effect when being incremented within the `if`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
All platforms
Issue related to the all platforms
bug
Something isn't working
good first issue
Good for newcomers
Launcher is just accepting fontsize, datapath and scr
Describe the bug
When trying to add parameters in Launcher like /density or any other, console shows error.
To Reproduce
TotalCrossApplication.run(DashboardSample.class, "/scr", "848x480x24", "/density", "1.0");
Devices:
Please complete the following information:
Additional context
Console Output:
The text was updated successfully, but these errors were encountered: