-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes activation key: tc.Deploy no longer require an activation key #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tc.Deploy no longer check/use the key but the /r option on deploy command line still can be used without errors; - Removes /r option from the standard help; - DeploySettings.rasKey is no longer filled; - GlobalConstantPool no longer provide a "free sdk limitation" if DeploySettings.rasKey is null because TC is FOSSA
- Removes RegisterSDK because is no longer being used; - tc.Deploy: - Affected by deletion of RegisterSDK - Fix /r case arg skip; - Removes FREE_BLOCKED_PLATFORMS - Removes Convert import (no longer used) - Launcher: - Affected by deletion of RegisterSDK - No longer has the key insertion screen - Remove /r from instructions helper - Remove track of TC usage - Fix some warnings
- Removes hasKey and isFreeSDK attributes from DeploySettings - the above changes have affected tc.Deploy/J2TC and the errors have been corrected
haave you tested it putting the key? |
ItaloYeltsin
approved these changes
Jun 19, 2020
flsobral
pushed a commit
that referenced
this pull request
Jul 16, 2020
…#53) * Removes activation key: tc.Deploy no longer require an activation key - tc.Deploy no longer check/use the key but the /r option on deploy command line still can be used without errors; - Removes /r option from the standard help; - DeploySettings.rasKey is no longer filled; - GlobalConstantPool no longer provide a "free sdk limitation" if DeploySettings.rasKey is null because TC is FOSSA * Removes activation key: RegisterSDK class is no longer being used - Removes RegisterSDK because is no longer being used; - tc.Deploy: - Affected by deletion of RegisterSDK - Fix /r case arg skip; - Removes FREE_BLOCKED_PLATFORMS - Removes Convert import (no longer used) - Launcher: - Affected by deletion of RegisterSDK - No longer has the key insertion screen - Remove /r from instructions helper - Remove track of TC usage - Fix some warnings * Removes activation key: DeploySettings.hasKey no longer makes sense - Removes hasKey and isFreeSDK attributes from DeploySettings - the above changes have affected tc.Deploy/J2TC and the errors have been corrected
flsobral
pushed a commit
that referenced
this pull request
Jul 24, 2020
…#53) * Removes activation key: tc.Deploy no longer require an activation key - tc.Deploy no longer check/use the key but the /r option on deploy command line still can be used without errors; - Removes /r option from the standard help; - DeploySettings.rasKey is no longer filled; - GlobalConstantPool no longer provide a "free sdk limitation" if DeploySettings.rasKey is null because TC is FOSSA * Removes activation key: RegisterSDK class is no longer being used - Removes RegisterSDK because is no longer being used; - tc.Deploy: - Affected by deletion of RegisterSDK - Fix /r case arg skip; - Removes FREE_BLOCKED_PLATFORMS - Removes Convert import (no longer used) - Launcher: - Affected by deletion of RegisterSDK - No longer has the key insertion screen - Remove /r from instructions helper - Remove track of TC usage - Fix some warnings * Removes activation key: DeploySettings.hasKey no longer makes sense - Removes hasKey and isFreeSDK attributes from DeploySettings - the above changes have affected tc.Deploy/J2TC and the errors have been corrected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story short
Totalcross was a proprietary technology that had a system of activation keys for each dev. In early 2020 we joined the open souce movement and now that key system no longer makes sense. In these first changes we aim to:
First user
My PC:
Final users
The pom.xml no longer needs
<totalcross.activation_key>
. Before:After:
Still in pom.xml,
<build>
tag no longer needs<activationKey>
. Before:After:
Finally, you no longer need a key in your RunSampleApplication class, just:
Next steps
The next step is to delete the
RegisterSDK
class and check for more implications 👍