-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid SDL display bounds dependency #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SDL_Window` and `TCSurface` depended
viewport instance is no longer needed
acmlira
added
c++
Linux
Issue related to the platform Linux
Linux ARM
Issue related to the platform Linux ARM
labels
Aug 13, 2020
otavio
approved these changes
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So nice! @acmlira good work in splitting the commits! So easier to review!
ItaloYeltsin
approved these changes
Aug 14, 2020
ItaloYeltsin
added a commit
that referenced
this pull request
Aug 14, 2020
This reverts commit d10c241.
ItaloYeltsin
added a commit
that referenced
this pull request
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid SDL display bounds dependency
The functions of SDL had issues in distros like Ångström:
SDL_GetDisplayBounds();
and
SDL_GetDisplayUsableBounds();
and
SDL_CreateRenderer();
they depended on some certain workaround to run correctly on any systems. They were useful to get the size of the screens.
Plus
We now introduce 3 environment variables for execution. Since we do not have an automatic viewport they need to be set up they are:
width
in pixelsheight
in pixelsIn case the standard resolution is not met, it will be 640x400. That should change soon.
Pull request
I think that squash should not be done since each commit is semantically and syntaxically correct.