Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid SDL display bounds dependency #99

Merged
merged 7 commits into from
Aug 14, 2020

Conversation

acmlira
Copy link
Contributor

@acmlira acmlira commented Aug 13, 2020

Avoid SDL display bounds dependency

The functions of SDL had issues in distros like Ångström:

SDL_GetDisplayBounds();

and

SDL_GetDisplayUsableBounds();

and

SDL_CreateRenderer();

they depended on some certain workaround to run correctly on any systems. They were useful to get the size of the screens.

Plus

We now introduce 3 environment variables for execution. Since we do not have an automatic viewport they need to be set up they are:

TC_WIDTH TC_HEIGHT TC_FULLSCREEN
Description Size of width in pixels Size of height in pixels Is fullscreen or not
Values int int bool

In case the standard resolution is not met, it will be 640x400. That should change soon.

Pull request

I think that squash should not be done since each commit is semantically and syntaxically correct.

@acmlira acmlira added c++ Linux Issue related to the platform Linux Linux ARM Issue related to the platform Linux ARM labels Aug 13, 2020
@acmlira acmlira requested a review from flsobral August 13, 2020 17:36
@acmlira acmlira self-assigned this Aug 13, 2020
@acmlira acmlira requested a review from ItaloYeltsin August 13, 2020 17:37
Copy link
Member

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice! @acmlira good work in splitting the commits! So easier to review!

@ItaloYeltsin ItaloYeltsin merged commit d10c241 into master Aug 14, 2020
@ItaloYeltsin ItaloYeltsin deleted the feature/avoid-sdl-display-bound branch August 14, 2020 13:03
ItaloYeltsin added a commit that referenced this pull request Aug 14, 2020
ItaloYeltsin added a commit that referenced this pull request Aug 14, 2020
@ItaloYeltsin ItaloYeltsin restored the feature/avoid-sdl-display-bound branch August 14, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux ARM Issue related to the platform Linux ARM Linux Issue related to the platform Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants