fix potensial bug: when n_importance not divided by up_sample_steps w… #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential bug:
in
renderer.py
Whenself.n_importance
is not divisible byself.up_sample_steps
will cause line 365 inrenderer.py
reshape error due to shape differ.For example when setting
self.up_sample_steps=6
andself.n_importance=64
andself.n_samples=64
it will result tensorsdf
in last iteration of up sample loop to have shape of(batch_size, 124)
(since 64//6=10, we missing the non-zero remainder at each loop-iteration) instead of(batch_size, 128)
.While in line 341
n_samples = self.n_samples + self.n_importance
result 128 instead of 124, so this will makes_val = ret_fine['s_val'].reshape(batch_size, n_samples).mean(dim=-1, keepdim=True)
to cause a reshape error.I simply add accumulative non-zero reminder to
n_importance
argument passed toself.up_sample
at last iteration to resolve this bug.