Skip to content

Commit

Permalink
fix: memoize params
Browse files Browse the repository at this point in the history
  • Loading branch information
JulianWielga committed Nov 19, 2024
1 parent 089e089 commit 47f0da6
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/FederatedComponent.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { Fragment, RefAttributes } from "react";
import React, { Fragment, RefAttributes, useMemo } from "react";
import ReactDOM from "react-dom";
import { FederatedModuleProvider, FederatedModuleProviderProps } from "./FederatedModuleProvider";
import { useFederatedModule } from "./hooks";
Expand Down Expand Up @@ -36,8 +36,10 @@ function FederatedComponentRender<P extends NonNullable<unknown>, T>(
) {
const [, scopeValue, , , , query] = splitUrl(url as ModuleUrl);

const searchParams = new URLSearchParams(query);
const params = Object.fromEntries(searchParams.entries()) as P;
const params = useMemo(() => {
const searchParams = new URLSearchParams(query);
return Object.fromEntries(searchParams.entries()) as P;
}, [query]);

return (
<FederatedModuleProvider url={url} fallback={fallback} buildHash={buildHash}>
Expand Down

0 comments on commit 47f0da6

Please sign in to comment.