Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1286] tests: schema caching fix #151

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[NU-1286] tests: schema caching fix #151

merged 1 commit into from
Nov 27, 2023

Conversation

coutoPL
Copy link
Member

@coutoPL coutoPL commented Nov 27, 2023

helm-k8s-streaming-test failed because the empty list of schemas was cached and the schemas added before the test execution were not taken into consideration during testing. The scenario was classified as invalid because there was no schema for Kafka's topic used in the scenario.

@coutoPL coutoPL requested a review from arkadius November 27, 2023 11:53
Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@coutoPL coutoPL merged commit 9b63159 into main Nov 27, 2023
3 checks passed
@coutoPL coutoPL deleted the bugfix/NU-1286 branch November 27, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants