Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1230] Refactor process activity API tests #5334

Merged
merged 3 commits into from
Jan 16, 2024
Merged

[NU-1230] Refactor process activity API tests #5334

merged 3 commits into from
Jan 16, 2024

Conversation

lukasz-bigorajski
Copy link
Contributor

@lukasz-bigorajski lukasz-bigorajski commented Jan 10, 2024 •
edited by coutoPL
Loading

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

updated: #5335
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1230.refactor.process.activity.api.tests branch 2 times, most recently from 92a3b94 to a7a8420 Compare January 15, 2024 09:59
coutoPL
coutoPL approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@coutoPL coutoPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I've added some minor comments. It's up to you to address them or not.

designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ScenarioActivitySpec.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ScenarioActivitySpec.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ScenarioActivitySpec.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ScenarioActivitySpec.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ScenarioActivitySpec.scala Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ScenarioActivitySpec.scala Outdated Show resolved Hide resolved
designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ScenarioActivitySpec.scala Outdated Show resolved Hide resolved
@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1230.refactor.process.activity.api.tests branch from a7a8420 to d7219cb Compare January 16, 2024 13:59
@lukasz-bigorajski lukasz-bigorajski merged commit b9977d1 into staging Jan 16, 2024
16 checks passed
@lukasz-bigorajski lukasz-bigorajski deleted the nu.1230.refactor.process.activity.api.tests branch January 16, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coutoPL coutoPL coutoPL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasz-bigorajski @coutoPL