Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: support mixed indices and column names for dtypes and column selection #198

Closed
lukapeschke opened this issue Mar 4, 2024 · 0 comments · Fixed by #206
Closed

refactor: support mixed indices and column names for dtypes and column selection #198

lukapeschke opened this issue Mar 4, 2024 · 0 comments · Fixed by #206
Assignees
@lukapeschke
Labels
🦀 rust 🦀 Pull requests that edit Rust code feature request 🐍 python 🐍 Pull requests that edit Python code
Milestone
v0.10.0

Comments

@lukapeschke
Copy link
Collaborator

lukapeschke commented Mar 4, 2024 •
edited
Loading

Also add some information about selected columns.

  • name: str
  • index: int
  • dtype: DType
  • name_from: "provided" | "looked_up" | "generated"
  • dtype_from: "provided_by_index" | "provided_by_name" | "guessed"
@lukapeschke lukapeschke added 🐍 python 🐍 Pull requests that edit Python code 🦀 rust 🦀 Pull requests that edit Rust code feature request labels Mar 4, 2024
@lukapeschke lukapeschke added this to the v0.10.0 milestone Mar 4, 2024
@lukapeschke lukapeschke self-assigned this Mar 4, 2024
@lukapeschke lukapeschke mentioned this issue Mar 4, 2024
Merged
lukapeschke added a commit that referenced this issue Mar 18, 2024
@lukapeschke
feat: support mixed indices and column names for dtypes and column se…
bf7bd88 
…lection

Work items:

* Introduced a new type providing information about a column: `ColumnInfo`
* `ExcelSheet.selected_columns` now returns a list of ColumnInfo for all
  selected columns
* `ExcelSheet.available_columns` now returns a list of ColumnInfo for all
  available columns
* A lot of to/from python code has been wrapped in traits to have less
  manual validation

closes #198
@lukapeschke lukapeschke mentioned this issue Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukapeschke lukapeschke

Labels
🦀 rust 🦀 Pull requests that edit Rust code feature request 🐍 python 🐍 Pull requests that edit Python code
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

feat: support mixed indices and column names for dtypes and column selection ToucanToco/fastexcel
1 participant
@lukapeschke