Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(excelsheet): column_names should work with use_columns #217

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

lukapeschke
Copy link
Collaborator

closes #214

closes #214

Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke lukapeschke added bug Something isn't working ✋ need review ✋ labels Mar 29, 2024
@lukapeschke lukapeschke requested a review from PrettyWood March 29, 2024 17:00
@lukapeschke lukapeschke self-assigned this Mar 29, 2024
@lukapeschke lukapeschke changed the title fix(excelsheet): use_columns should work when columns are skipped fix(excelsheet): column_names should work with use_columns Mar 29, 2024
@lukapeschke lukapeschke merged commit 4dae4e8 into main Mar 29, 2024
22 checks passed
@lukapeschke lukapeschke deleted the fix-214 branch March 29, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

column_names are taken partially when use_columns does not include all columns
2 participants