Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: raise SheetNotFoundError when reading a missing sheet name #222

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: raise SheetNotFoundError when reading a missing sheet name #222

merged 2 commits into from
Apr 5, 2024

Conversation

PrettyWood
Copy link
Member

closes #221

lukapeschke
lukapeschke approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@lukapeschke lukapeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@PrettyWood PrettyWood merged commit 21f7f22 into main Apr 5, 2024
22 checks passed
@PrettyWood PrettyWood deleted the fix/221 branch April 5, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukapeschke lukapeschke lukapeschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load_sheet_by_name raises generic CalamineError instead of SheetNotFoundError
2 participants
@PrettyWood @lukapeschke