Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce ExcelTable object #287

Merged
merged 9 commits into from
Sep 24, 2024
Merged

feat: introduce ExcelTable object #287

merged 9 commits into from
Sep 24, 2024

Conversation

lukapeschke
Copy link
Collaborator

closes #204

@lukapeschke
first draft
6a63b2d 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke
refactor: single implem for record_batch_from_data_and_columns
80f68e7 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke
refactor: introduce common method to create RecordBatch from iterator
8a71a91 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke
refactor: use common functions as much as possible
390e142 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke
refactor: introduce a common data module
14dc3a4 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke lukapeschke self-assigned this Sep 18, 2024
@lukapeschke
feat: add python implem & tests
babe5e9 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke lukapeschke marked this pull request as ready for review September 18, 2024 16:11
@lukapeschke lukapeschke added 🐍 python 🐍 Pull requests that edit Python code 🦀 rust 🦀 Pull requests that edit Rust code proposal feature request and removed 🔨 WIP 🔧 labels Sep 18, 2024
PrettyWood
PrettyWood requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall
I would add some doc comments on new traits and functions

@lukapeschke
fix(deps): bump mypy and ruff minimum versions
8d032fe 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke
docs: add requested docstrings to new data module
c74c23d 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke
chore: lint
a3d9139 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke
Copy link
Collaborator Author

@PrettyWood added docstrings in c74c23d

@PrettyWood PrettyWood merged commit af79c6a into main Sep 24, 2024
23 checks passed
@PrettyWood PrettyWood deleted the introduce-table-object branch September 24, 2024 19:43
@wdoppenberg wdoppenberg mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrettyWood PrettyWood PrettyWood approved these changes

Assignees

@lukapeschke lukapeschke

Labels
🦀 rust 🦀 Pull requests that edit Rust code feature request proposal 🐍 python 🐍 Pull requests that edit Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Reading Excel Tables
2 participants
@lukapeschke @PrettyWood