feat: mimic excel behavior to convert float to string #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrettyWood
changed the title
rust_decimal smart display for float representation as string
lukapeschke
approved these changes
Oct 7, 2024
src/types/dtype.rs
Outdated
| /// ... | ... | ... | ||
| /// 123456.123456789 | 123456.1235 | 123456.1 | ||
| /// | ||
| /// Excel also trims trailing zeros and the decimal point if there are no fractional part. |
There was a problem hiding this comment.
Suggested change
| /// Excel also trims trailing zeros and the decimal point if there are no fractional part. | |
| /// Excel also trims trailing zeros and the decimal point if there is no fractional part. |
src/types/dtype.rs
Outdated
| /// Excel also trims trailing zeros and the decimal point if there are no fractional part. | ||
| /// | ||
| /// We have no notion of wide cell or standard cell here so we keep at most 9 digits after the | ||
| /// decimal point and trim trailing zeros. |
There was a problem hiding this comment.
Suggested change
| /// decimal point and trim trailing zeros. | |
| /// decimal point and trim trailing zeroes. |
There was a problem hiding this comment.
I prefer this spelling which is more common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #289