feat: fallback to string if dtype cannot be infered #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukapeschke
reviewed
Oct 21, 2024
src/types/dtype.rs
Outdated
Comment on lines
287
to
289
| } else { | ||
| Ok(DType::String) | ||
| } |
There was a problem hiding this comment.
Logic LGTM, but I'd like to have a log message in that case, to avoid bug reports regarding this behaviour. Seems like a good opportunity to introduce https://pyo3.rs/v0.22.3/ecosystem/logging WDYT ?
|
PrettyWood
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #277