Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take Screenshot hotkey and separate folder for screenshots and split images #223

Closed
Avasam opened this issue Apr 22, 2023 · 2 comments · Fixed by #248
Closed

Take Screenshot hotkey and separate folder for screenshots and split images #223

Avasam opened this issue Apr 22, 2023 · 2 comments · Fixed by #248
Labels
enhancement New feature or enhancement request Included in next release

Comments

@Avasam
Copy link
Collaborator

Avasam commented Apr 22, 2023

Is your feature request related to a problem? Please describe.

When building a split image folder, I like to take several images at a time to evaluate good candidates for split points, and then mask the selected image as needed before inserting it into my actual series of split images.

Describe the solution you'd like

I think this flow would be easier if I could bind a key to taking a screenshot (preferably without opening the image immediately), as well as set a separate folder path where these images would be saved, so they wouldn't clutter my in-progress split image folder with images that I probably won't use.

Describe alternatives you've considered
N/A

Additional context
Copied from Avasam#59

@Avasam Avasam added the enhancement New feature or enhancement request label Apr 22, 2023
@Avasam
Copy link
Collaborator Author

Avasam commented Apr 22, 2023

Comment copied from Avasam#59 (comment)

I don't mind adding a screenshot hotkey, I think it makes sense.
I don't think there's a canonical screenshot shortcut for apps, so I'd probably add it to AutoSplit's hotkey system (it's easy to do since I last refactored it anyway) rather than a Qt shortcut.

I can also add a config textfield to select an alternate screenshot path (defaults to the splits images path if empty). I could see myself using it as well.

Finally, I'm not sure if I'd want the behaviour of opening screenshots to be different between the hotkey and the button. Or if I'd rather have it be configurable. (both reusing the same config)

@Avasam
Copy link
Collaborator Author

Avasam commented Jun 24, 2023

Decided to also implement the option to not open the file. I'm not a huge fan of how there's no indication that a screenshot has been taken when using the hotkey, but it's optional and probably know what you're doing at that point. I can improve later.
For example, I might wanna consider offering to open the containing folder instead. And toast/notification system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement request Included in next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant