Remove Javadocs from Maven's install phase, make Debian/GitHub Actions specific pomfile. #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows github actions to continue to build the Javadocs without normal developers having to edit or remove the path to the Javadoc executable every time.
Javadocs can still be built by running `mvn javadoc:javadoc` or `mvn javadoc:jar` (Developers are responsible for properly configuring their path to their Javadoc executable. See Previous Commit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for changes and summary. Addresses issue #3519. Individual developers are now responsible for building their own Javadocs and making necessary tweaks to the Pom file to automate them.
pom_deb.xmlis now used for GitHub Actions' workflow. It can also be used on Debian-based distributions such as Ubuntu, Mint, and ZorinOS. It may or may not be compatible with MacOSX and other BSD/Linux/Unix systems. To do so, Maven will need to be ran with the--fileargument. IDE helper scripts may not work, or may need editing.The
pom_deb.xmlfile will always assume the javadoc executable is in the Java_Home directory, under the bin folder.