Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update jira plugin #142

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ageof2
Copy link
Contributor

@ageof2 ageof2 commented Sep 25, 2020

Jira functionality changed to Lib(php-jira-rest-client) and some errors in the current implementation fixed

@Toxantron
Copy link
Owner

Toxantron commented Sep 26, 2020

Thank you for another contribution, I am really happy to see a big org pick up the project and start contributing.

Unfortunately your IDE seems to have other indentation settings, which marks a lot of unchanged lines as changed and breaks GIT history in many places. While 4 space indentation is standard and I use it in other projects as well, for this project I would like to maintain proper diff detection.

Also I don't agree with declaring the $jiraConfiguration as part of the ControllerBase because it is specific to a single controller. Could you explain your reasons for the change, maybe I just don't see the issue with the current usage of the config?

@ageof2
Copy link
Contributor Author

ageof2 commented Sep 27, 2020

I'm sorry that we have different IDE settings and that you have additional effort. Which IDEs or exact settings do you use? The reason for the recording was that the JiraConfiguration was not available in the Jira controller. Although the variable was accessed there, it was never "imported". That's why my idea was there in the base controller that config is imported and all controllers from there inherit according to their integration. If you have a better idea, I would be happy :)

@Toxantron
Copy link
Owner

Today I use VSCode with 4 space indentation and for new files I wouldn't mind. For existing and renamed files I would prefer avoiding indentation changes, if it's not too much trouble.

@ageof2
Copy link
Contributor Author

ageof2 commented Sep 27, 2020

No subject, then I know for the next PR. Should I finish the indentations so that you can release the PR?

@Toxantron
Copy link
Owner

Yes please, there is also a conflict from my recent activities. As you might have noticed I found time up here in Denmark to work on a couple of older issues.

…eature/update_jira_plugin

# Conflicts:
#	src/templates/jira_source.html
@ageof
Copy link
Contributor

ageof commented Sep 29, 2020

Conflicts are solved. Ready for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants