Refactor and extend aux patterns #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds "low blink" and "high blink" patterns to single color aux LEDs. Also changes how the configuration is stored (backwards compatible by introducing a USE_EXTENDED_INDICATOR_PATTERNS macro).
Adds "low blink" and "high blink" patterns to single color aux LEDs.
By adding another "color" (7H) which turns the aux LEDs off, independent of the pattern. Enabled for USE_BUTTON_LED builds.
SiteRelEnby
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this branch was to add two more aux patterns: low blinking and high blinking. On its way I also added some refactoring, for example:
TICK_DURING_STANDBYchecks because it would not have built without it anywayUSE_OLD_BLINKING_INDICATORandUSE_FANCIER_BLINKING_INDICATOR– not used anymoreMost likely you don't want to merge this as is, but maybe it's useful for you anyway.
I haven't checked if there are any targets which don't build anymore due to insufficient flash memory.