Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-47) wsus-config-update-products: Fixes Duplicate Product Name Selection #48

Merged

Conversation

amr952
Copy link
Contributor

@amr952 amr952 commented Jan 14, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #46

Task list

  • Resource/Class documentation added/updated in README.md?
  • Examples appropriately added/updated?
  • Unit tests added/updated?
  • Integration tests added/updated (where possible)?

Copy link
Owner

@TraGicCode TraGicCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amr952 ,

Thank you for the pull request. Is there an already open issue that i can link to this pull-request? If not can you create one that describes the problem so i can use that when i create the changelog for the new version of the module?

Thanks

@TraGicCode
Copy link
Owner

Hey @amr952 ,

Just pinging you again since i haven't heard back from you about my initial request above.

@mike406
Copy link

mike406 commented Jan 22, 2021

Hi @TraGicCode please do not merge this request just yet. @amr952 and I are testing out files that I sent him in our production environments. Once he reports back we can discuss the PR. Thank you.

@TraGicCode
Copy link
Owner

Hey @mike406 ,

I will hold off until given the thumbs up.

Thank you

@mike406
Copy link

mike406 commented Mar 5, 2021

@amr952 Following up on this PR. Are we good to go on it?

@mike406
Copy link

mike406 commented Mar 12, 2021

@TraGicCode We can go ahead with this PR. It passes all of my tests.

@amr952
Copy link
Contributor Author

amr952 commented Mar 12, 2021

I agree - This was been working great for me for the past few weeks.

@TraGicCode TraGicCode changed the title wsus-config-update-products: Duplicate Product Name Selection (GH-47) wsus-config-update-products: Duplicate Product Name Selection Mar 20, 2021
@TraGicCode TraGicCode changed the title (GH-47) wsus-config-update-products: Duplicate Product Name Selection (GH-47) wsus-config-update-products: Fixes Duplicate Product Name Selection Mar 20, 2021
@TraGicCode TraGicCode merged commit 8a96f5c into TraGicCode:master Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Server 2019 and 10 product is not correctly chosen anymore due to duplicate products being listed
3 participants