Skip to content

Commit

Permalink
Remove the callbacks from the filesystem_store
Browse files Browse the repository at this point in the history
This is should have no functional difference, these callbacks
were only used for testing and used up needless memory for live
systems. This PR should save about 32 bytes per FileEntry.
  • Loading branch information
allada committed Jul 2, 2023
1 parent 497446b commit e2e62d2
Show file tree
Hide file tree
Showing 6 changed files with 385 additions and 251 deletions.
3 changes: 3 additions & 0 deletions cas/store/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,8 @@ rust_test(
"//util:buf_channel",
"//util:common",
"//util:error",
"//util:evicting_map",
"@crate_index//:async-lock",
"@crate_index//:filetime",
"@crate_index//:futures",
"@crate_index//:lazy_static",
Expand All @@ -424,4 +426,5 @@ rust_test(
"@crate_index//:tokio",
"@crate_index//:tokio-stream",
],
proc_macro_deps = ["@crate_index//:async-trait"],
)
2 changes: 1 addition & 1 deletion cas/store/default_store_factory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ pub fn store_factory<'a>(
store_factory(&config.fast, store_manager).await?,
store_factory(&config.slow, store_manager).await?,
)),
StoreConfig::filesystem(config) => Arc::new(FilesystemStore::new(&config).await?),
StoreConfig::filesystem(config) => Arc::new(<FilesystemStore>::new(&config).await?),
StoreConfig::ref_store(config) => Arc::new(RefStore::new(&config, store_manager.clone())),
StoreConfig::size_partitioning(config) => Arc::new(SizePartitioningStore::new(
&config,
Expand Down
Loading

0 comments on commit e2e62d2

Please sign in to comment.