Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SIGTERM #454

Closed
aaronmondal opened this issue Dec 7, 2023 · 1 comment
Closed

Handle SIGTERM #454

aaronmondal opened this issue Dec 7, 2023 · 1 comment
Assignees
@aaronmondal
Labels
bug Something isn't working

Comments

@aaronmondal
Copy link
Member

We already handle SIGINT #434 to allow killing a container via Ctrl+c. Some scheduling systems (like K8s) use SIGTERM to terminate processes in containers and we should support that as well with similar behavior to SIGINT.

At the moment, terminating a native-link deployment in k8s takes forever because SIGTERM is ignored and after an unnecessarily long grace period shut down via SIGKILL.
@aaronmondal aaronmondal added the bug Something isn't working label Dec 7, 2023
@aaronmondal aaronmondal self-assigned this Dec 7, 2023
@aaronmondal
Copy link
Member Author

This was implemented in #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronmondal aaronmondal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronmondal