Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SIGTERM #462

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Handle SIGTERM #462

merged 1 commit into from
Dec 12, 2023

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Dec 8, 2023 •
edited by allada
Loading

This enables rapid shutdown of deployments in k8s.

This change is Reviewable

@aaronmondal
Handle SIGTERM
20fb405 
This enables rapid shutdown of deployments in k8s.
adam-singer
adam-singer approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: , note given this might not be common knowledge, maybe link something describing this as a pattern to use for k8s in the pr description, ex https://cloud.google.com/blog/products/containers-kubernetes/kubernetes-best-practices-terminating-with-grace

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aaronmondal)

@aaronmondal aaronmondal merged commit e49049c into TraceMachina:main Dec 12, 2023
20 checks passed
@aaronmondal aaronmondal mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-singer adam-singer adam-singer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronmondal @adam-singer