Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompletenessCheckingStore requires all Directory digest values be uploaded to store but not required by spec #747

Closed
allada opened this issue Mar 10, 2024 · 0 comments · Fixed by #748
Closed

CompletenessCheckingStore requires all Directory digest values be uploaded to store but not required by spec #747

allada opened this issue Mar 10, 2024 · 0 comments · Fixed by #748

Comments

@allada
Copy link
Member

allada commented Mar 10, 2024

Completeness checking store currently requires all directory objects be uploaded to the CAS if set, however the GRPC does not require this as long as they are part of the Tree proto.

Spawned from:
https://nativelink.slack.com/archives/C06758HJQF8/p1710107198046199
allada added a commit to allada/nativelink-fork that referenced this issue Mar 10, 2024
@allada
Completeness checking store should not check if directory digests exist
56c0a84 
REv2 does not require clients to upload directory digests. Instead
they are only required to upload the tree root which has all the
directories in it.

closes TraceMachina#747
@allada allada mentioned this issue Mar 10, 2024
Merged
allada added a commit to allada/nativelink-fork that referenced this issue Mar 11, 2024
@allada
Completeness checking store should not check if directory digests exist
e8cffc2 
REv2 does not require clients to upload directory digests. Instead
they are only required to upload the tree root which has all the
directories in it.

closes TraceMachina#747
aaronmondal pushed a commit that referenced this issue Mar 15, 2024
@allada
Completeness checking store should not check if directory digests exi…
e979e31 
…st (#748)

REv2 does not require clients to upload directory digests. Instead
they are only required to upload the tree root which has all the
directories in it.

closes #747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Completeness checking store should not check if directory digests exist allada/nativelink-fork
1 participant
@allada