Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining static content to s3 #1444

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Move remaining static content to s3 #1444

merged 1 commit into from
Oct 31, 2024

Conversation

SchahinRohani
Copy link
Contributor

@SchahinRohani SchahinRohani commented Oct 31, 2024 •
edited by allada
Loading

Description

Transition remaining static content to the new s3 nativelink-cdn

How Has This Been Tested?

bun dev

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

aaronmondal
aaronmondal approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained, and all files reviewed

@SchahinRohani SchahinRohani merged commit 8a3869c into TraceMachina:main Oct 31, 2024
35 checks passed
@SchahinRohani SchahinRohani deleted the remove/wix-content branch October 31, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmondal aaronmondal aaronmondal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchahinRohani @aaronmondal