Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage update config (serde_until.rs) #1479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leodziki
Copy link

@leodziki leodziki commented Nov 14, 2024

Description

Completed tests for nativelink/nativelink-config/src/serde_until.rs
Bazel test and cargo test both passed. And Pre-commit passed in direnv and everything is perfect.
Fixes #1401

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

How Has This Been Tested?

Bazel test, cargo test and pre-commit

Checklist

  • Tests added/amended
  • bazel test //... passes locally

This change is Reviewable

@leodziki
Copy link
Author

I would like to receive feedback on my PR.
@aaronmondal ,
@MarcusSorealheis

@aaronmondal
Copy link
Member

Could you remove the files that are unrelated to serde_utils.rs?

Coverage update for serde_until completed. Bazel test, cargo test, pre-commit passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

☔ Help us improve code coverage
2 participants