Make global tekton lock ConfigMap resolvable #1530
Conversation
In the current setup the `nativelink-image-tags` configmap acts as a global lock for the nativelink kustomization. This means that it's not possible to change toolchain configurations after the fact. This change makes the config map name configurable to allow for setups that need more flexibility, such as multi-toolchain setups or setups where worker types change over time.
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 10 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @SchahinRohani)
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Looks very useful to have a configurable configmap name!
Also like the new naming for the kubernetes/resoruces. Great one!
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Cargo Dev / macos-13, Coverage, Installation / macos-13, NativeLink.com Cloud / Remote Cache / macos-14
In the current setup the
nativelink-image-tagsconfigmap acts as a global lock for the nativelink kustomization. This means that it's not possible to change toolchain configurations after the fact.This change makes the config map name configurable to allow for setups that need more flexibility, such as multi-toolchain setups or setups where worker types change over time.
This change is