-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Azure Blob Store #1554
Open
amankrx
wants to merge
1
commit into
TraceMachina:main
Choose a base branch
from
amankrx:azure-blob-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amankrx
force-pushed
the
azure-blob-store
branch
from
December 26, 2024 13:02
88ea9e1
to
024eccb
Compare
amankrx
force-pushed
the
azure-blob-store
branch
from
December 26, 2024 13:10
024eccb
to
042699f
Compare
amankrx
force-pushed
the
azure-blob-store
branch
from
December 29, 2024 22:10
042699f
to
ce79966
Compare
amankrx
force-pushed
the
azure-blob-store
branch
from
December 29, 2024 22:21
ce79966
to
d5bf750
Compare
amankrx
force-pushed
the
azure-blob-store
branch
from
December 29, 2024 22:42
d5bf750
to
7e2a535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Azure Blob Store implementation and closely aligns with the AWS S3 implementation.
This utilizes the azure_sdk libraries (azure_core, azure_storage, and azure_storage_blobs). The libraries are still unofficial and being developed, so we should be mindful of any breaking changes in the future.
Apart from that, I started my development by first creating a POC: https://gist.github.com/amankrx/45e7d2a6ed935aa13dda0318681af2ad
This POC tests the get and upload blobs with all the default features disabled for Azure SDK. This creates a custom HttpClient with manually signing the requests to perform the transactions.
My current implementation still utilizes the
hmac_rust
feature enabled for signing the request. Please do let me know if weneed any updates here.
The implementations are mostly the same as what we have for Amazon S3. The key difference here is that I have implemented a Custom HTTP Client for executing the requests.
I still have to test it against an actual Blob Storage and implement a testing framework. I have created this PR to get an idea if my current implementation is on the right track.
Regarding the testing framework, I believe we would have to create some custom mocking requests to test the functions. Azure SDK does support the mocking using mock transport(https://github.com/Azure/azure-sdk-for-rust/tree/main/eng/test/mock_transport), but the mocking library isn't as mature enough as what we have for S3.
Fixes #1542
/claim #1542
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
I tested it locally using the
bazel test
command with theazure_blob_backend_with_local_fast_cas.json5
file, configured to use the actual blob storage. Additionally, I created a test suite to cover both individual happy paths and error scenarios.Checklist
bazel test //...
passes locallygit amend
see some docsThis change is