Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis wrapper types #941

Closed
wants to merge 1 commit into from

Conversation

zbirenbaum
Copy link
Contributor

@zbirenbaum zbirenbaum commented May 29, 2024

PR for early feedback. Main issues here are:

  1. We could just throw a Serialize, Deserialize on all these structs instead of going through this effort and having to maintain them in two places.
  2. PlatformProperties is going to take some work to get to dynamically serialize properly. We ideally want to be able to get it in the form of: property_name: { value_type: [Exact|Minimum|...], value: [String|u64] } but that's deceptively difficult to go to and from. Its also impossible to do from the proto's since the way things are currently done the platform property manager resolves those types dynamically.

Relies on #927 #937


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented May 29, 2024

CLA assistant check
All committers have signed the CLA.

@zbirenbaum zbirenbaum force-pushed the redis-wrapper-types branch from bb2ec9a to 6f02ad7 Compare May 29, 2024 18:59
Copy link
Contributor

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1.
Reviewable status: 0 of 1 LGTMs obtained, and pending CI: Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Publish image, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, ubuntu-20.04 / stable, ubuntu-22.04 / stable, windows-2022 / stable, and 1 discussions need to be resolved


nativelink-util/src/action_messages.rs line 107 at r1 (raw file):

    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.write_fmt(format_args!(
            "{}:{}",

Would it be useful to also display the hash code?

@zbirenbaum zbirenbaum force-pushed the redis-wrapper-types branch 2 times, most recently from 4cf68cd to 6b611e0 Compare May 29, 2024 22:17
Early feedback changes, likely to just add serialize to the original
structs instead
@zbirenbaum zbirenbaum force-pushed the redis-wrapper-types branch from 6b611e0 to 72abdde Compare May 31, 2024 18:49
@zbirenbaum zbirenbaum mentioned this pull request Jun 4, 2024
4 tasks
@zbirenbaum
Copy link
Contributor Author

Outdated and alternative solution was merged. Closing

@zbirenbaum zbirenbaum closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants